Review: Needs Fixing

Looks good, but needs a unit test (make check ought to complain about/fail on < 
100% coverage with this) and integration test. This doesn't supply an 
implementation with NetworkManager -- if that doesn't support it, it should 
trigger a warning at least.
-- 
https://code.launchpad.net/~xnox/netplan/+git/netplan/+merge/324020
Your team Developers of netplan is subscribed to branch netplan:master.

-- 
Mailing list: https://launchpad.net/~netplan-developers
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~netplan-developers
More help   : https://help.launchpad.net/ListHelp

Reply via email to