On 2016-07-21 at 16:01:30 +0200, Paolo Abeni <pab...@redhat.com> wrote: > Hi all, > > I have a couple of doubts about packet accounting in netsniff-ng: > currently in receive_to_xmit() pkts_seen is incremented before the > packet type check, but failing the latter will cause the packet to be > ignored, pretty much as if it failed to pass the filter. > In walk_t3_block() and recv_only_or_dump() the accounting is performed > after the check, should the receive_to_xmit() do the same ?
Yes, receive_to_xmit() should definitely do the same. The current behavior is wrong. > Should pkts_drops be incremented if the packet type filter fails ? Yes, I think they should be accounted for as well. > If there is agreement I can send patches implementing the above. Would be much appreciated, thanks! -- You received this message because you are subscribed to the Google Groups "netsniff-ng" group. To unsubscribe from this group and stop receiving emails from it, send an email to netsniff-ng+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
