Hey Dan, replies inline.
On 8/25/2011 10:35 PM, Dan Wendlandt wrote:
As a note, jaypipes is working on defining a common source skeleton
for openstack projects: https://github.com/openstack/openstack-skeleton/
That's perfect! I'll work on getting things updated to these standards.
On Thu, Aug 25, 2011 at 4:22 PM, Dan Wendlandt <[email protected]
<mailto:[email protected]>> wrote:
Hi Tyler,
Thanks again for working on this. I think the break down between
client/common/server makes a lot of sense.
I pulled this branch and have a couple questions/comments:
- It seems like plugins other than the cisco plugin is not in the
branch. Was that intentional? Or was this branch just intended
as an example of how we might do packaging?
In only packaged up the Cisco plugin as a proof-of-concept, since it was
the biggest. I'll work on getting the others packaged appropriately.
- Given that we will likely have more plugins in the future, does
it make sense to have a top level plugins directory, then have
that directory contain sub-directories for specific plugins?
That's easy enough to do.
- Seems like the LICENSE, TESTING files are missing form the top
level directory.
- It would be good to stay in line with nova and other projects as
much as possible, for example, by keeping a run_tests.sh and
run_tests.py at the top level directory. Probably the same thing
for /bin, /etc, etc. Is there something about the packaging that
is preventing us from doing that?
There's no reason LICENSE and TESTING can't be, and I don't think it
should be an issue for run_tests.*. I put /etc in specific package
directories to keep the configuration files separate (i.e. not mixing
cisco-plugin/etc/ files with server/etc/). I think it's possible to
setup it up this way if it's preferred, but I would think the separation
would be good.
--
Mailing list: https://launchpad.net/~netstack
Post to : [email protected]
Unsubscribe : https://launchpad.net/~netstack
More help : https://help.launchpad.net/ListHelp
