As the first one to completely mess this up (I clicked approve on a review (+2) when there wasn't a (+1) yet) I figured I'd send out a link describing the protocol in case anyone other than me missed this in the documentation.
>From http://wiki.openstack.org/GerritJenkinsGithub: Any Openstack developer may propose or comment on a change (including voting +1/0/-1 on it). A vote of +2 is allowed from core reviewers, but should only be used after another core member has voted +1 and there are no outstanding -1 votes. If you're coming from Launchpad, a +2 vote is equivalent to setting a merge prop status to "Approved". OpenStack projects have a policy of requiring two core reviewers to approve a patch. Once a review receives one +2 vote, Jenkins will run the proposed change and verify the merge. If Jenkins successfully tests the change, and there are no -2 code review votes, the change will be automatically merged into the repository. ... The result of this is that if you +2 something before anyone else reviewed it, it will just get submitted which violates our 2-reviewer policy. Ooops. Sorry about that.. Thanks, Brad -- Mailing list: https://launchpad.net/~netstack Post to : [email protected] Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp
