Hi On Mon, Mar 26, 2012 at 3:15 AM, Yong Sheng Gong <[email protected]> wrote:
> Quantum should accept the --config-file=/etc/quantum/quantum.conf argument > and the plugin.ini should be found under the same directory with > quantum.conf > > So we have two bugs: > 1.stack.sh, should be "screen_it q-svc "cd $QUANTUM_DIR && > PYTHONPATH=.:$QUANTUM_CLIENT_DIR:$PYTHONPATH python > $QUANTUM_DIR/bin/quantum-server --config-file= > $QUANTUM_CONF_DIR/quantum.conf" > 2.quantum should honour the quantum.conf to find the plugin.ini > I like #2, and in fact, Salvatore has had a bug and a patch on this for eons: https://bugs.launchpad.net/quantum/+bug/803086 . We avoided pushing it in Essex b/c of the lack of a good backward compatibility plan, but I suggest we just push it and eliminate the plugins.ini early in Folsom, regardless of backward compat. However, I'm not sure those two changes alone are sufficient, since plugins also have their own config files (note the issue I mentioned with the ovs_quantum_plugin.ini below) Dan > > > Regards, > > > [email protected] wrote: ----- > > To: [email protected] > From: Dan Wendlandt <[email protected]> <[email protected]> > Sent by: [email protected] > Date: 03/26/2012 03:27PM > Subject: [Netstack] quantum + devstack broken by recent devstack commit > > > This commit from friday seems to have broken quantum + devstack in a > subtle way: > https://github.com/openstack-dev/devstack/commit/17ff9763da677f3db0339a395c558cdb881d5d56 > > It changes stack.sh so that quantum config files are copied to > /etc/quantum and edited, rather than edited directly in > /opt/stack/quantum/etc . The problem is that when Quantum loads, it checks > a variety of locations for a possible configuration files, and it always > checks for an etc/ directory in the current directory first, before > checking /etc/quantum (see: python-quantumclient/quantum/common/config.py) > . Because the config files modified by stack.sh are in /etc/quantum, not > the local etc/ directory, a fresh Quantum will always start with the > SamplePlugin, rather than the plugin configured by stack.sh, leading to > great confusion :) > > Note: the patch is also broken in that it moves the ovs_quantum_plugin.ini > file directly to /etc/quantum, rather than to > /etc/quantum/plugins/openvswitch . > > I'm not sure if the committer had a real reason to make this change, or if > they were just trying to make Quantum more like other openstack services. > So I'll give them the option of either reverting the fix, or cleaning it > up :) > > However, this also highlights the fact that Quantum's mechanism for > searching for conf files is no longer inline with other projects like nova > (it likely was when Quantum was started as a project). For example: it > seems that the find_config_files method in nova/openstack/common/cfg.py no > longer looks for a etc/ directory in the local dir. > > This again emphasizes the importance of OpenStack common. To that end, > I've added work to leverage the openstack common library to our list of > "community projects": http://wiki.openstack.org/QuantumStarterBugs . A > while back, I did some of the ground work to identify chunks of code that > would be well suited for moving into openstack common, so anyone who is > interested can easily get started. Check out: > http://wiki.openstack.org/QuantumOpenstackCommon > > Dan > > > > -- > ~~~~~~~~~~~~~~~~~~~~~~~~~~~ > Dan Wendlandt > Nicira Networks: www.nicira.com > twitter: danwendlandt > ~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > -- > Mailing list: https://launchpad.net/~netstack > Post to : [email protected] > Unsubscribe : https://launchpad.net/~netstack > More help : https://help.launchpad.net/ListHelp > > > > -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dan Wendlandt Nicira Networks: www.nicira.com twitter: danwendlandt ~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- Mailing list: https://launchpad.net/~netstack Post to : [email protected] Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp
