In message <[email protected]> you wrote:

> Author: dynis
> Date: Sat Jan  3 01:01:10 2009
> New Revision: 5957
> 
> [...]
> +             /*      Check if the frame data runs off the end of the file
> +             */
> +             if ((int)(gif_bytes - block_size) < 0) {

Understanding the difference between signed vs unsigned overflow in C is
not always intuitive and obvious so I'm a bit puzzled why we wouldn't go
for the more obvious:

        if (gif_bytes < (unsigned int)block_size) {

with gif_bytes being unsigned and block_size signed.

John.
-- 
John Tytgat
[email protected]

Reply via email to