In message <[email protected]> you wrote:
> Author: MarkieB > Date: Fri May 29 13:29:53 2009 > New Revision: 7627 > > URL: http://source.netsurf-browser.org?rev=7627&view=rev > Log: > turn magic numbers into relevant quantity > > Modified: > branches/MarkieB/upload/gtk/gtk_window.c > > Modified: branches/MarkieB/upload/gtk/gtk_window.c > URL: > http://source.netsurf-browser.org/branches/MarkieB/upload/gtk/gtk_window.c?rev=7627&r1=7626&r2=7627&view=diff > ============================================================================== > --- branches/MarkieB/upload/gtk/gtk_window.c (original) > +++ branches/MarkieB/upload/gtk/gtk_window.c Fri May 29 13:29:53 2009 > @@ -265,16 +265,17 @@ > time, gpointer data) > { > char *filename; > + int offset = strlen("file://"); > filename = strdup((gchar *)(selection->data)); > - filename[strlen("file://")] = '\0'; > + filename[offset] = '\0'; > if (strcmp(filename, "file://") == 0) { > - filename[7] = '/'; > - filename += 7; > + filename[offset] = '/'; > + filename += offset; > printf("filename %s\n", filename); > /* then add filename to gadget */ > > gtk_drag_finish(cont, TRUE, FALSE, time); > - filename -= 7; > + filename -= offset; > } > free(filename); > } Extra bonus point to be gained when using "size_t offset = sizeof("file://")-1;" instead of the using the strlen() runtime function. I expect most today's compilers this won't make a difference but still... John. -- John Tytgat [email protected]
