On Mon, 2009-06-22 at 10:31 +0100, Daniel Silverstone wrote:
> Index: test/basictests.c
> +START_TEST (test_lwc_get_hash_value_ok)
> +{
> + lwc_get_hash_value(intern_one);
> +}
> +END_TEST
Should this test that the hash is non-zero? Is there any guarantee of
value which we're placing on this hash at all? If not, then this bit of
the test is fine.
> + tcase_add_test_raise_signal(tc_basic,
> + test_lwc_get_hash_value_aborts
> + SIGABRT);
Please put the tcase_add_test_raise_signal with the rest of them inside
the NDEBUG define which guards against issues debugging the tests.
> Index: include/libwapcaplet/libwapcaplet.h
[snip]
this bit is fine.
> Index: src/libwapcaplet.c
[snip]
As is this bit.
Decide if my first question has merit, and move the
tcase_add_test_raise_signal as per my second comment and then it's
mergeable.
D.
--
Daniel Silverstone http://www.netsurf-browser.org/
PGP mail accepted and encouraged. Key Id: 2BC8 4016 2068 7895
