On Thu, 2009-07-23 at 16:31 +0100, John-Mark Bell wrote: > On Thu, 2009-07-23 at 16:36 +0200, Daniel Silverstone wrote:
> > > +bool parse_number(const char *data, bool maybe_negative, bool real, > > > + css_fixed *value, size_t *consumed) > > > > This function feels like it ought to be part of libcss. Or am I > > misunderstanding where numbers are defined? > > It has one too. I was in two minds about exposing it, however. In fact, I wasn't :) The answer is that attribute values containing numbers use a different format from CSS numbers. Therefore, this has to be a separate function. Otherwise (ignoring the c->style comparison in layout.c, which I've decided to leave alone pending a wholesale fixup of the comparisons in that file), I think I've dealt with most of the issues you've highlighted. I'm refactoring dump.c now. J.
