On Mon, Aug 10, 2009 at 4:09 AM, John-Mark Bell<[email protected]> wrote: > On Sun, 2009-08-09 at 22:08 +0800, Bo Yang wrote: >> Hi, >> >> After more than one week coding, I have completed the Events >> module. The API support status is at >> http://wiki.netsurf-browser.org/LibDOM/Events_Support_Status. And the >> Events module is added to the Core module and pass the DOMTS as the >> Core module does. Also, the leak test for the Events module is well, >> too. So I think it is applicable for review. > > That's great. Can you provide a breakdown of the Events test status?
Of course, the three attachments are the detail of 3 level test results. Generally, because of there are test cases for Events model in DOMTS, so I add the Events function and re-run the Core tests to test the Events module, and the result are: level1: Total: 527 Passed: 421 Failed: 106 Conversion Error: 2 Compile Error: 19 Run Error: 52 Not Support: 33 level2: Total: 282 Passed: 155 Failed: 127 Conversion Error: 5 Compile Error: 14 Run Error: 90 Not Support: 18 level3: Total: 722 Passed: 68 Failed: 654 Conversion Error: 135 Compile Error: 313 Run Error: 116 Not Support: 90 You will see, the result of level1 are exactly the same with the Core model. For level2 and level3, the passed test are a little less than the Core module. That's because, there are some changes to Core module which is not in the Events module. After merge the Core to trunk and merge the changes to the Core to Events, I think the level2 and level3 will be OK, too. > I'll try to find time to review the code tomorrow. Thanks a lot! >> It is better if we can merge the Core module firstly, and then we >> start the review of Events module and start write the HTML module >> meanwhile. > > I agree. Core should be mostly ready for merge. I've not yet looked at > your latest changes since my round 3 email but, assuming that you've > sorted the editorial issues I raised, it should be good to go. > Similarly, I'll try to find time tomorrow to deal with this. Thanks! Regards! Bo
