On Tue, 2009-08-11 at 10:22 +0800, Bo Yang wrote:
> On Tue, Aug 11, 2009 at 7:47 AM, John-Mark Bell<[email protected]> 
> wrote:
> > On Thu, 2009-08-06 at 10:32 +0000, [email protected] wrote:

> >> Modified: branches/struggleyb/libdom-remain/src/core/attr.c
> >> URL: 
> >> http://source.netsurf-browser.org/branches/struggleyb/libdom-remain/src/core/attr.c?rev=9079&r1=9078&r2=9079&view=diff
> >> ==============================================================================
> >> --- branches/struggleyb/libdom-remain/src/core/attr.c (original)
> >> +++ branches/struggleyb/libdom-remain/src/core/attr.c Thu Aug  6 05:32:21 
> >> 2009
> >> @@ -102,15 +100,16 @@
> >>  }
> >>
> >>  /**
> >> - * Initialis a dom_attr
> >> - *
> >> - * \param a          The dom_attr
> >> - * \param doc        The document
> >> - * \param name       The name of this attribute node
> >> - * \param namespace  The namespace of this attribute
> >> - * \param prefix     The prefix
> >> - * \param specified  Whether this node is a specified one
> >> - * \param result     The returned node
> >> + * Initialise a dom_attr
> >> + *
> >> + * \param a          The dom_attr
> >> + * \param doc        The document
> >> + * \param name       The name of this attribute node
> >> + * \param namespace   The namespace of this attribute
> >> + * \param prefix     The prefix
> >> + * \param specified   Whether this node is a specified one
> >> + * \param result     The returned node
> >> + * \return DOM_NO_ERR on success, appropriate dom_exception on failure
> >
> > Whitespace.
> 
> There are no tabs in this comment, I think it is a good comment, what
> do you mean by saying whitespace?

Namespace and specified have an extra space after them.

> >> Modified: branches/struggleyb/libdom-remain/src/core/node.h
> >> URL: 
> >> http://source.netsurf-browser.org/branches/struggleyb/libdom-remain/src/core/node.h?rev=9079&r1=9078&r2=9079&view=diff
> >> ==============================================================================
> >> --- branches/struggleyb/libdom-remain/src/core/node.h (original)
> >> +++ branches/struggleyb/libdom-remain/src/core/node.h Thu Aug  6 05:32:21 
> >> 2009
> >> @@ -55,8 +56,8 @@
> >>       void *vtable;                   /**< The protected vtable */
> >>
> >>       struct lwc_string_s *name;      /**< Node name (this is the local 
> >> part
> >> -                                      * of a QName in the cases where a
> >> -                                      * namespace exists) */
> >> +                                                              * of a 
> >> QName in the cases where a
> >> +                                                              * namespace 
> >> exists) */
> >
> > Ditto.
> >
> 
> And there is no tab in comments in above, too. :)

The last 2 lines are overly indented.


J.


Reply via email to