On Thu, 2009-08-06 at 07:02 +0000, [email protected] wrote: > Modified: branches/MarkieB/gtkmain/content/fetch.h > URL: > http://source.netsurf-browser.org/branches/MarkieB/gtkmain/content/fetch.h?rev=9075&r1=9074&r2=9075&view=diff > ============================================================================== > --- branches/MarkieB/gtkmain/content/fetch.h (original) > +++ branches/MarkieB/gtkmain/content/fetch.h Thu Aug 6 02:02:58 2009 > @@ -39,6 +39,16 @@ > FETCH_AUTH, > FETCH_CERT_ERR, > } fetch_msg; > + > +typedef enum { > + FETCH_ERROR_NO_ERROR, > + FETCH_ERROR_CERT_ERROR, > + FETCH_ERROR_AUTHENTICATION_ERROR, > + FETCH_ERROR_HTTP_NOT2_ERROR, > + FETCH_ERROR_COULDNT_RESOLVE_HOST_ERROR, > + FETCH_ERROR_PARTIAL_FILE_ERROR, > + FETCH_ERROR_UNKNOWN_CURL_ERROR > +} fetch_error_code;
I'd lose the trailing _ERROR, here. > Modified: branches/MarkieB/gtkmain/content/fetchers/fetch_curl.c > URL: > http://source.netsurf-browser.org/branches/MarkieB/gtkmain/content/fetchers/fetch_curl.c?rev=9075&r1=9074&r2=9075&view=diff > ============================================================================== > --- branches/MarkieB/gtkmain/content/fetchers/fetch_curl.c (original) > +++ branches/MarkieB/gtkmain/content/fetchers/fetch_curl.c Thu Aug 6 > 02:02:58 2009 > @@ -911,13 +919,15 @@ > human_friendly_bytesize(dltotal)); > fetch_send_callback(FETCH_PROGRESS, f->fetch_handle, > fetch_progress_buffer, > - (unsigned long) percent); > + (unsigned long) percent, > + FETCH_ERROR_NO_ERROR); > } else { > snprintf(fetch_progress_buffer, 255, > messages_get("ProgressU"), > human_friendly_bytesize(dlnow)); > fetch_send_callback(FETCH_PROGRESS, f->fetch_handle, > - fetch_progress_buffer, 0); > + fetch_progress_buffer, 0, > + FETCH_ERROR_NO_ERROR); > } Please make the above align correctly. > @@ -1121,7 +1136,8 @@ > if (f->only_2xx && strncmp(f->url, "http", 4) == 0 && > (http_code < 200 || 299 < http_code)) { > fetch_send_callback(FETCH_ERROR, f->fetch_handle, > - messages_get("Not2xx"), 0); > + messages_get("Not2xx"), 0, > + FETCH_ERROR_HTTP_NOT2_ERROR); > return true; > } Ditto. J.
