Dear NetSurf Developers,

I am responding to a message posted to csa.announce on August 9, which
may give you a fair indication of how much time I have to keep up with
developments online. :-(

However, I have been keeping up quite regularly with the NetSurf builds
via SVN. I have made changes to the RISC OS GUI code that I have never
tried to submit. These changes keep rolling over from one SVN update to
the next. For example, I prevent NetSurf from passing left/right
keypresses on because moving the cursor in (say) the address bar would
cause PCITV to change channels. Small stuff, but it does indicate that I
am quite familiar with C and the WIMP. My primary shortcoming as an
assistant would be in the amount of time I can commit.

So just how much work do you estimate will be required to align the WIMP
development with the core? And do you already have plenty of offers from
others with much time to spare?
-- 
Regards, Christopher Martin.

Index: render/layout.c
===================================================================
--- render/layout.c     (revision 8638)
+++ render/layout.c     (working copy)
@@ -3493,18 +3493,13 @@
        else {
                /* over constrained => examine direction property
                 * of containing block */
-               if (containing_block->style) {
-                       if (box->parent->style->direction ==
-                                       CSS_DIRECTION_LTR)
-                               /* left wins */
-                               right = -left;
-                       else if (box->parent->style->direction ==
-                                       CSS_DIRECTION_RTL)
+               if (containing_block->style && (box->parent->style->direction ==
+                                       CSS_DIRECTION_RTL)) {
                                /* right wins */
                                left = -right;
                }
                else {
-                       /* no parent style, so assume LTR */
+                       /* assume LTR in all other cases */
                        right = -left;
                }
        }

Reply via email to