On Sun, 28 Mar 2010 13:58:25 +0100, Daniel Silverstone wrote:
> The jmb/new-cache branch has been merged as of 10180.
>
> Please note the attached review points are yet to be addressed.
Not mentioned in the review points, but I'd like to flag these up:
desktop/browser.c
/** \todo Sort parameters out here */
download_window = gui_download_window_create(
llcache_handle_get_url(stream),
llcache_handle_get_header(stream, "Content-Type"),
NULL, 0, NULL);
/** \todo Ensure parameters are correct here */
download_window = gui_download_window_create(
llcache_handle_get_url(handle),
llcache_handle_get_header(handle,
"Content-Type"),
NULL, 0, NULL);
NULL is being passed for gui_window...
Chris
