> ----- Original Message ----- > From: John-Mark Bell <[email protected]> > To: [email protected] > Subject: Re: Segfault on Twitter - ID: 3113770 > Date: Thu, 25 Nov 2010 23:14:12 +0000 > > > On Sun, 2010-11-21 at 20:11 +0100, Levon Haykazyan wrote: > > Hi, > > > > The attached little patch should fix the above mentioned bug. > > It may prevent the crash, but I'm not convinced it's the correct > solution. Returning false from that function indicates to the caller > that memory was exhausted when fulfilling their request. That's > certainly not what has happened when we've removed a cookie that has > expired. > Agreed. But returning true while freeing the parameter c is also not correct. Returning true from that function indicates to the caller that c was successfully inserted into database. That's certainly not what has happened.
> > I don't know whether this is the right place to send the patch, > > but for some reason I couldn't post it in the bug tracker. > > This is the right place, yes. > > Thanks, > > > J. > Thanks, Levon -- You Rock! Your E-Mail Should Too! Signup Now at Rock.com and get 2GB of Storage! http://connections.rock.com/user/displayUserRegisterPage.kickAction?as=116748&STATUS=MAIN
