Am Montag, den 03.01.2011, 22:31 +0100 schrieb John-Mark Bell
<[email protected]>:
One licensing issue: atari/scancode.h is declared as being
"Copyright (c) Heimsoeth & Borland 1988", but without details of
how
that code is licensed. At the very least, we need to ensure that
whatever licence it uses is compatible with GPLv2. Can you provide
more
details about where that header came from?
Will have to find an alternative... Heimsoeth & Borland is now called
Borland...
As far as the core changes are concerned, it's mostly fine. You have
this twice:
+#ifdef __MINT__
+ #ifndef ceilf
+ #define ceilf(x) (float)ceil((double)x)
+ #endif
+ #undef min
+ #define min(a,b) ((a)<(b)?(a):(b))
+ #undef max
+ #define max(a,b) ((a)>(b)?(a):(b))
+#endif
Firstly, the definition of ceilf can be moved to utils.h, so we can
avoid duplicate code. See the beos/haiku-specific definition of
strtof
for an example.
Ok.
Secondly, I don't understand why you've redefined min/max -- they're
defined identically to this in utils.h
There where problems using the gcc builtin functions,... but I didn't
know that this builtin functions are also defined within utils.h. I will
have a look at that, probably it can be solved there.
Greets
