Thanks (for noticing the masking issues too - happily I don't think my erroneous implementation caused problems in real life).
Feels good to not be maintaining a fork again, however small. Jamie. On 23 Aug 2011, at 21:14, John-Mark Bell wrote: > On Tue, 2011-08-23 at 11:57 +0100, James Montgomerie wrote: >> The attached patch completes support for page-break-after, >> page-break-before, page-break-inside in libCSS. >> >> To do this, I've implemented a css_computed_page structure, an >> instantiation of which is pointed to (if used) by css_computed_style's >> page element (previously a NULL void *), then just filled in the >> property setters getters etc. Hopefully you'll find the style and >> intentions all in keeping with how things should be in libCSS. > > Thanks for this. I've committed it as r12645. There were a couple of > incorrect masks in the propset code, which I've fixed up. Otherwise, it > was fine as is. > > Again, thanks. > > > J.
