On Tue, May 27, 2014 at 06:38:10PM +0100, Chris Young wrote: > On Tue, 27 May 2014 11:06:20 +0100, Vincent Sanders wrote: > > > May I ask if (aside from the dumb mistakes) the feature is working as > > expected now? It ought to have removed any delays if the network was > > unable to fetch the search providers icons and made the whole thing > > more robust. > > It seems fine, other than not picking up the icon on some occasions. > Actually, I had a thought about that - is it fetching, and not > notifying the frontend when the new icon is ready?
OK done some debugging on gtk and it is always notifying. However I have discovered something very aggrivating: - At initialisation it is setting the provider name with null bitmap. - The cache then quickly supplies the provider icon and that fecth completes, the callback is called with the provider name and bitmap. - The default icon fetch then completes and it sets the provider bitmap back to the default. I am currently trying to figure how to stop the default icon fetch overriding the correct provider image. -- Regards Vincent http://www.kyllikki.org/
