On 2020-03-22, [email protected] <[email protected]> wrote: > diff -urN a/include/nslog/nslog.h b/include/nslog/nslog.h > --- a/include/nslog/nslog.h Sun Feb 23 01:49:32 2020 > +++ b/include/nslog/nslog.h Sun Mar 22 18:08:23 2020 > @@ -17,6 +17,13 @@ > > #include <stdarg.h> > > +#if defined(__GNUC__) > +# define PRINTF(fmt, args) __attribute__ ((format (printf, 2, 3)))
Did you mean `#define PRINTF(pos, args) __attribute__ ((format (printf, pos, args)))` here? > +#elif defined(_PLAN9) > +# pragma varargck nslog__log argpos 2 > +# define PRINTF(pos, args) > +#endif What about when neither of these cases match? Maybe something like this would be better #else # if defined(_PLAN9) # pragma varargck nslog__log argpos 2 # endif # define PRINTF(pos, args) #endif
