ni...@lysator.liu.se (Niels Möller) writes: > I've pushed a branch "aes-reorg" to the public repo, implementing this > change.
I'm now about to merge this into the master branch. Some questions: Now that the more ciphers in nettle work with fix key size, maybe it would be a good idea to drop the length argument also from the nettle_set_key_func typedef? This is used primarily for struct nettle_cipher (nettle-meta.h), where using a function pointer with more than one size makes little sense. Since various incompatible changes are being made for nettle-2.8 anyway, this could be a good time. Also, other AES-style algorithms, in particular, twofish and camellia, could have similar changes as AES. E.g., the twofish implementation appear to zero-pad keys of unusual sizes up to the next standard size. Is that an important feature, or can I change it to just have twofishN_setkey (struct twofishN_ctx *, const uint8_t *key), for n = 128, 192 and 256? Regards, /Niels -- Niels Möller. PGP-encrypted email is preferred. Keyid C0B98E26. Internet email is subject to wholesale government surveillance. _______________________________________________ nettle-bugs mailing list nettle-bugs@lists.lysator.liu.se http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs
