On Tue, Feb 28, 2017 at 7:48 AM, Niels Möller <[email protected]> wrote:
> Gustavo Serra Scalet <[email protected]> writes:
>
>> I noticed there is no merging/update activities on the gitlab website:
>> https://git.lysator.liu.se/nettle/nettle/merge_requests?scope=all&state=all
>>
>> I wonder if it's used.
>
> It's used mainly for the plain git hosting. I rarely use the more
> advance features, and almost never access the web interface.

Would it be possible to disable then the merge request option in the
gitlab interface? There are already 5 patches there.

Most likely you need to go to -> Edit project and disable the issue
tracker and the merge commits for everyone (at least that's the
process in the new gitlab).

>> The reason for asking is that I'm willing to integrate a
>> ppc64le-specific implementation using SIMD registers for the SHA-2
>> algorithm so I would create an Issue to discuss it and then submitting
>> the code as a Merge Request. But only if that's the way for
>> upstreaming code on nettle. If not, please advise if this list can be
>> used.
>
> Discussion should take place on this list. You can mail patches here, or
> create a merge request on gitlab. But in the latter case, please send a
> note here too, otherwise it might be overlooked.

I attach a patch to document that process. I use CONTRIBUTION.md show
it shows prominently on the gitlab interfaces.

regards,
Nikos
From 5bfed966da2c384d0cd2e24f22437dfb70b2532a Mon Sep 17 00:00:00 2001
From: Nikos Mavrogiannopoulos <[email protected]>
Date: Tue, 28 Feb 2017 10:03:24 +0100
Subject: [PATCH] Made current contibution rules explicit

Signed-off-by: Nikos Mavrogiannopoulos <[email protected]>
---
 CONTRIBUTING.md | 21 +++++++++++++++++++++
 Makefile.in     |  2 +-
 README          |  2 ++
 3 files changed, 24 insertions(+), 1 deletion(-)
 create mode 100644 CONTRIBUTING.md

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
new file mode 100644
index 0000000..92200ab
--- /dev/null
+++ b/CONTRIBUTING.md
@@ -0,0 +1,21 @@
+# nettle -- Information about our contribution rules
+
+# Test suite:
+
+   New functionality should be accompanied by a test case which verifies
+its correctness, on successful use of the new functionality, as well as on
+failure cases. The nettle test suite is run on "make check".
+
+# Continuous Integration (CI)
+
+We utilize a continuous integration systems, using gitlab-ci.
+
+This is run on a repository mirror at:
+https://gitlab.com/gnutls/nettle
+
+# Sending patches
+
+Please do not utilize the gitlab web interfaces. They are not
+being followed on. Please send your patches to [email protected]
+
+
diff --git a/Makefile.in b/Makefile.in
index 135542f..bd8f9a6 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -217,7 +217,7 @@ DISTFILES = $(SOURCES) $(HEADERS) getopt.h getopt_int.h \
 	libnettle.map.in libhogweed.map.in \
 	config.guess config.sub install-sh texinfo.tex \
 	config.h.in config.m4.in config.make.in	Makefile.in \
-	README AUTHORS COPYING.LESSERv3 COPYINGv2 COPYINGv3 \
+	README CONTRIBUTING.md AUTHORS COPYING.LESSERv3 COPYINGv2 COPYINGv3 \
 	INSTALL NEWS TODO ChangeLog \
 	nettle.pc.in hogweed.pc.in \
 	$(des_headers) descore.README \
diff --git a/README b/README
index ca873a3..8355739 100644
--- a/README
+++ b/README
@@ -42,6 +42,8 @@ Read the manual. Mail me if you have any questions or suggestions.
 You may want to subscribe to the nettle-bugs mailing list. See
 <URL: http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs>.
 
+See CONTRIBUTING.md for information on contibuting patches.
+
 
 Happy hacking,
 /Niels Möller <[email protected]>
-- 
2.9.3

_______________________________________________
nettle-bugs mailing list
[email protected]
http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs

Reply via email to