Hello, 2017-10-16 19:46 GMT+03:00 Niels Möller <[email protected]>: > Dmitry Eremin-Solenikov <[email protected]> writes: > >> Signed-off-by: Dmitry Eremin-Solenikov <[email protected]> >> --- >> Makefile.in | 4 +- >> cfb.c | 165 ++++++++++++++++++++++++++ >> cfb.h | 87 ++++++++++++++ >> nettle.texinfo | 106 +++++++++++++++-- >> testsuite/.gitignore | 1 + >> testsuite/.test-rules.make | 3 + >> testsuite/Makefile.in | 2 +- >> testsuite/cfb-test.c | 287 >> +++++++++++++++++++++++++++++++++++++++++++++ >> testsuite/testutils.c | 179 ++++++++++++++++++++++++++++ >> testsuite/testutils.h | 7 ++ >> 10 files changed, 829 insertions(+), 12 deletions(-) >> create mode 100644 cfb.c >> create mode 100644 cfb.h >> create mode 100644 testsuite/cfb-test.c > > I'm about to merge this version. Thanks for your contribution and > patience! Some final points:
Thank you! > Any reason you chose 2015 as the year in the copyright headers? Should I > just change to 2017 on your copyright lines? It was because this code was originally written in 2015. Yes, you can change year to 2017. I think there should be no issues with that. > > The patch didn't apply cleanly, because it seems you had applied some > local fixes to the testsuite/.gitignore file. So I had to figure that > out and then fix the .gitignore files first. Hmm. Strange. Oh, I branched this from master-updates, rhat than just master, sorry. > I'd like to have traditional GNU-style ChangeLog entries for all > changes. I'll write up a short summary. It aids integration of patches > if the contributor includes ChangeLog entries, preferably outside of the > patch itself to avoid patch conflicts. OK, I will include such entries into further patch submissions. -- With best wishes Dmitry _______________________________________________ nettle-bugs mailing list [email protected] http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs
