On Mon, Oct 31, 2022 at 10:58 PM Niels Möller <ni...@lysator.liu.se> wrote:
> Maamoun TK <maamoun...@googlemail.com> writes: > > > Sounds good. I modified the MR to have its own poly1305-blocks.asm with > > poly1305.m4 file for shared macros. > > Nice. I wonder if it's possible to organize the macro as smaller easier > to understand pieces. I'm afraid I have no concrete suggestion; maybe > I'll try something with the x86_64 code. > I got your point. Small macros are easy to handle but maybe adding some in-between comments would also make it easier to go through by reader. please check out my last edit on poly1305.m4 > However, I had to have > > poly1305-blocks.c too so fat build stays functioning, let me know if we > can > > do it in a simpler way. > > I merged my refactoring changes to master now. The new > _nettle_poly1305_update is now the only caller of the multi-block > function, so I hope it should be possible to have the C loop defined > locally in poly1305-update.c (depending on HAVE_NETTLE_poly1305_blocks, > and maybe HAVE_NETTLE_fat_poly1305_blocks, like in a few other places). > I replaced poly1305-blocks.c with C function inside poly1305-update.c to make the fat build functioning. I have a new merge request https://git.lysator.liu.se/nettle/nettle/-/merge_requests/56 that targets the master branch now. regards, Mamone Regards, > /Niels > > -- > Niels Möller. PGP key CB4962D070D77D7FCB8BA36271D8F1FF368C6677. > Internet email is subject to wholesale government surveillance. > _______________________________________________ nettle-bugs mailing list -- nettle-bugs@lists.lysator.liu.se To unsubscribe send an email to nettle-bugs-le...@lists.lysator.liu.se
