Daiki Ueno <u...@gnu.org> writes: > Niels Möller <ni...@lysator.liu.se> writes:
>> One failure is the new side-channel test failing with mini-gmp. Which is >> expected, the test should just be skipped in mini-gmp builds (similar to >> several other sc tests). > > Yes, I'm attaching the patch for this. I've committed and pushed that part of patch. >> The other is a complaint from ubsan. I guess it's related to the label >> == NULL case. I don't know what's the proper place for a fix, maybe it's >> not in the new code. I think the Nettle APIs should generally allow size >> == 0, ptr == NULL more or less everywhere, even where libc functions we >> use formally require ptr != NULL. > > This is similar to this issue: > https://gitlab.com/gnutls/gnutls/-/issues/1306 > where we passed NULL to sha*_update in the GnuTLS code, though it turned > to be a non-issue. I don't remember seeing that issue. I think it should be allowed to call sha*_update with 0, NULL (when size is null, there's no reason to ever attempt to dereference that pointer). I'll see if I can fix that. Regards, /Niels -- Niels Möller. PGP key CB4962D070D77D7FCB8BA36271D8F1FF368C6677. Internet email is subject to wholesale government surveillance. _______________________________________________ nettle-bugs mailing list -- nettle-bugs@lists.lysator.liu.se To unsubscribe send an email to nettle-bugs-le...@lists.lysator.liu.se
