Daiki Ueno <[email protected]> writes: >> The code change looks very reasonable. It needs a doc update, not sure >> if it also deserves any additional tests. > > I've updated the documentation.
I've merged to master-updates, will merge to master as soon as CI is happy (I had to fix a texinfo error). > Given that the code is already exercised > through drbg_ctr_aes256_init and drbg_ctr_aes256_random, I don't see the > need of dedicated tests, though it might make sense to extend the > existing tests with the ACVP test vectors we use[1]. It looks like that test uses a personalization string, so maybe not a great fit (even though it should be possiblt to have the testcode implement that personalization; I haven't look into how that is defined). Regards, /Niels -- Niels Möller. PGP key CB4962D070D77D7FCB8BA36271D8F1FF368C6677. Internet email is subject to wholesale government surveillance. _______________________________________________ nettle-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
