Nicolas,

Sebastien Roy wrote:
- Could m_ident be replaced by a proper version number passed as an argument to mac_register()?

What would be the functional difference between having it be the first
member of mac_register_t and having it be a separate argument?

It is currently a version number in the form of a string.  What did you
have in mind?  Are you just commenting on the name of the field
(m_version instead of m_ident?), or on its type?

I've decide to make this a uint_t and renamed it m_version. It will get automatically set by mac_alloc(), so there's no need for an extra mac_register() argument. I'll get rid of MAC_IDENT, and instead export a MAC_VERSION integer constant that gets passed in to mac_alloc(). Integral version numbers are probably sufficient, please scream now if you don't agree.

Thanks,
-Seb
_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to