Seb,
This looks really good, I have only a few minor comments.
* usr/src/lib/libdladm/common/libdladm.c
ND-001 215 You need to be able to identify the aggregation from which
you want to retrieve the defined VLANs. With these changes
it seems that it will always look for "aggr0".
* usr/src/lib/liblaadm/common/liblaadm.c
ND-002 60 Should update the notes on file syntax if it has changed.
ND-003 413 Isn't this going to cause a failure if the slash separator
is not present?
* usr/src/pkgdefs/SUNWckr/prototype_com
ND-004 90 mismerge?
* usr/src/pkgdefs/SUNWckr/prototype_i386
ND-005 89 mismerge?
197
264
371
* usr/src/pkgdefs/SUNWckr/prototype_sparc
ND-006 96 mismerge?
205
* usr/src/uts/common/io/aggr/aggr_port.c
ND-007 172-174 Use {} for multi-line for() block
* usr/src/uts/common/io/mac/mac.c
ND-008 180 Looks like a gratuitous change
ND-009 1043 Typo: s/zefo/zero
* usr/src/uts/common/sys/aggr_impl.h
ND-010 134 Could use another bit of the bitmask above
* Other files reviewed
usr/src/cmd/dladm/dladm.c
usr/src/cmd/rcm_daemon/common/network_rcm.c
usr/src/lib/libdladm/common/libdladm.h
usr/src/lib/liblaadm/common/liblaadm.h
usr/src/uts/Makefile.targ
usr/src/uts/Makefile.uts
usr/src/uts/common/Makefile.files
usr/src/uts/common/Makefile.rules
usr/src/uts/common/io/aggr/aggr_ctl.c
usr/src/uts/common/io/aggr/aggr_grp.c
usr/src/uts/common/io/aggr/aggr_lacp.c
usr/src/uts/common/io/aggr/aggr_recv.c
usr/src/uts/common/io/dld/dld_drv.c
usr/src/uts/common/io/dld/dld_proto.c
usr/src/uts/common/io/dld/dld_str.c
usr/src/uts/common/io/dls/dls.c
usr/src/uts/common/io/dls/dls_link.c
usr/src/uts/common/io/dls/dls_stat.c
usr/src/uts/common/io/dls/dls_vlan.c
usr/src/uts/common/io/mac/mac_stat.c
usr/src/uts/common/io/mac/plugins/mac_ether.c
usr/src/uts/common/sys/aggr.h
usr/src/uts/common/sys/dld.h
usr/src/uts/common/sys/dls.h
usr/src/uts/common/sys/dls_impl.h
usr/src/uts/common/sys/mac.h
usr/src/uts/common/sys/mac_ether.h
usr/src/uts/common/sys/mac_impl.h
usr/src/uts/intel/Makefile.intel.shared
usr/src/uts/intel/mac_ether/Makefile
usr/src/uts/sparc/Makefile.sparc.shared
usr/src/uts/sparc/mac_ether/Makefile
On May 19, 2006, at 1:03 PM, Sebastien Roy wrote:
Fellow Nemo enthusiasts,
This is a request for a code-review of the "Nemo MAC-Type Plugin
Architecture" component of Clearview. I'm setting a timer for
comments
that expires on June 2.
The webrev is located here:
http://www.sebweb.net/cr/webrev-mactype/
Apologies for the strange webrev URL. We'll hopefully soon be able to
run code-reviews from www.opensolaris.org itself, but we're unable
to do
that at this moment.
The work is comprised of two PSARC cases:
2006/248 Nemo MAC-Type Plugin Architecture
2006/249 Nemo Changes for Binary Compatibility
The cases' materials can be found on the clearview project page, at:
http://www.opensolaris.org/os/project/clearview/nemo-mactype-
plugins.txt
and
http://www.opensolaris.org/os/project/clearview/nemo-binary-
compatibility.txt
In brief, this work extends Nemo to include a framework for
dynamically
loadable MAC-Type modules (one for DL_ETHER is included in this work),
and also modifies the Nemo driver interfaces to support this framework
as well as well as making it possible to extend them in the future
in a
binary compatible way.
If any additional information is needed during your review, please let
me know.
Thanks,
-Seb
_______________________________________________
networking-discuss mailing list
[email protected]
--
Nicolas Droux, Solaris Kernel Networking
Sun Microsystems, Inc. http://blogs.sun.com/droux
_______________________________________________
networking-discuss mailing list
[email protected]
