replying to meem's comments.... > > > src/cmd/auditd/Makefile: > > > > > > + There appears to be quite a bit of brokenness in here that would > > > be nice to fix up. Specifically, SUBDIRS is never set so it > > > should be stripped from the targets, lines 75-78 should be > > > removed, `local_clobber' should be torched, a proper `clean' > > > target should be introduced, and `clobber' should come from > > > cmd/Makefile.targ. (Oh, and TEXT_DOMAIN is already set from > > > Makefile.cmd.) > > > > all accepted. > > The new `clean' target includes $(PROG), but that's supposed to be done > by `clobber', not `clean'. >
ah, fixed now. > > > src/cmd/cmd-inet/usr.sbin/in.ftpd/Makefile: > > > > > > * 12-13: While this probably works, it would be more consistent > > > to hoist PROG and SCRIPTS as well. > > > > > > > i'm not really sure what you mean here to be honest. can you elaborate > > a bit? thanks! > > Sorry; I meant that I would prefer to see PROG and SCRIPTS listed before > `include ../../../Makefile.cmd'. > ah, understood, thanks! fixed. > > > src/cmd/cmd-inet/usr.sbin/routeadm/Makefile: > > > > > > * 30: Remove blank line. > > > > > > * 34-37: None of this stuff should be needed since this is a > > > single-source-file program. > > > > > > > both accepted. > > Some other things I missed before: ROOTUSRSBINLINKS is listed twice, and > I'm not sure why the ROOTUSRSBINPROG target is needed in the `install' > dependency list. Also, why is $(SVCMETHOD) listed in the `all' target? > I though it was already built? > all fixed. > > > src/cmd/zoneadm/Makefile: > > > > > > * 34, 52: Likewise. > > > > fixed also. > > Looks good, though I just noticed the `clean' rule is incorrect; it > should be `$(RM) $(OBJS) $(POFILES)'. > sure, fixed. a few other minor fixes also, in a few places i'd retained METHOD instead of SVCMETHOD, as a result some method scripts weren't getting installed in the proto area (yp, svc-zones, and svc-mdmonitor). this webrev contains the latest changes: http://cr.grommit.com/~amaguire/onnv-quagga-updated-3/ thanks! alan This message posted from opensolaris.org _______________________________________________ networking-discuss mailing list [email protected]
