Code review for PSARC/2005/334 - Packet Filtering Hooks - is now open.
You can find the code review files at: http://cr.grommit.com/~darrenr/pfhooks-2006-7-19/review/ http://cr.grommit.com/~darrenr/pfhooks-2006-7-19/webrev/ For those on SWAN, the gate itself can be found at: /net/greatwall.prc/workspaces/pfh-gate-prc The parent gate/snapshot is onnv43 - our locally trimmed down version (minus the result of "make install") is: /net/ephron.prc/export/onnv43 Feedback on the changes by the 4th of August, 2006, would be appreciated. Note that there are some unresolved issues with respect to the use of b_prev that have bitten us a few times with this project, for which we've developed workarounds that could be considered "hacks". In the fullness of time OpenSolaris needs to stop using b_prev for storing the ifindex and at which point those hacks can be removed. Where appropriate, those changes cite the relevant bugs with comments next to the code. There are a number of bugs that this project will enable to be closed through the change of architecture from pfil/pfild to pfhooks. I haven't listed these bugs with this webrev as it isn't clear to me that this makes sense. The IPFilter upgrade and surya project will both require further changes and testing of this gate once they have completed putback into ON. The manual pages included with this code review are /not/ what will be distributed in the final product shipped, rather they are what the documentation team will use as input into the final product. All man pages in the gate are in nroff format. If it will help, I will look at generating text or html pages for review - but bear in mind, the changes accepted/made may not be used. Currently the only kernel memory leak we've stumbled across is documented in 6448003. Otherwise all of our test suites indicate success. Darren _______________________________________________ networking-discuss mailing list [email protected]
