I've completed everything from the command/misc set execpt for dladm.c
(which is of course the biggest chunk!). I've started dladm.c; I should
be able to finish it tomorrow and get you those comments.
Until then, here are my comments on the remaining 19 files.
-renee
-------------------------------------------------------------------------------
FEEDBACK ON TECHNICAL DOCUMENTATION/CODE
-------------------------------------------------------------------------------
Reviewer Name: Renee Danson
Document/Module Title: wifi-ws
Document/Module Version/Date: 9/26/06
-------------------------------------------------------------------------------
the 16 files not mentioned here: no comments
-------------------------------------------------------------------------------
-------------------------------------------------------------------------------
usr/src/cmd/svc/milestone/net-physical
-------------------------------------------------------------------------------
RD-01 61 Com Should mention secobj in this comment, too.
Might also note that linkprops will be init'd
later, after interfaces are plumbed.
RD-02 177 Cos Need to resolve XXX
RD-03 179 Func This is highly unlikely (or maybe not even
allowed?), but what if the interface is IPv6-
only? Shouldn't the init-linkprop be moved
after the v6 interfaces are plumbed, too?
-------------------------------------------------------------------------------
usr/src/lib/libbsm/audit_class.txt
-------------------------------------------------------------------------------
RD-04 28 Func This comment says you also need to edit audit.h.
But, I can't find audit.h. So it's not obvious
to me what exactly what this note means, but
I'd like to confirm that you've either done
what it is telling you to do, or you have a
reason not to.
-------------------------------------------------------------------------------
usr/src/lib/libbsm/common/adt_xlate.c
-------------------------------------------------------------------------------
RD-05 919 Func There are only 44 entries in the table, right?
-------------------------------------------------------------------------------
usr/src/cmd/dladm/dladm.c: comments coming soon
-------------------------------------------------------------------------------
Comment type key:
Func comment on functionality
Perf comment on performance
CodeStd comment on coding standards
Design comment on design
Edit editorial comment
Cos cosmetic comment
Com comment on missing comments
_______________________________________________
networking-discuss mailing list
[email protected]
