Judy Chen wrote:
> | EXPLAIN
> | ENETRESET, as the return value of ieee80211_ioctl(), is checked
> | and used by wifi drivers. For example, if the desired ESSID is
> | changed, ENETRESET is returned by ieee80211_ioctl(), wifi driver
> | then is supposed to re-start connecting to an AP with the specified
> | ESSID.
> | ENETRESET is ignored when ieee80211_ioctl() sending back ioctl ACK
> | message to config tools (dladm or wificonfig).
I c. Could you please add a comment in ieee80211_ioctl() before
calling miocack() explaining this?
> | EXPLAIN
> | Yes, it's the desired behavior. The desired rate is only for data
> | transfer. So usually the desired rate is checked and used when the
> | driver changes to RUN state.
> | If the driver is SCAN, the desired rate is set but driver don't have
> | to do anything.
> | If the driver is AUTH or ASSOC, the drate is checked against rates
> | supported by current ESS, nothing will be done if the drate is
> | supported, and re-connecting is required to check if another ESS
> | with specified drate can be found when the drate is not supported
> | by the current ESS.
Could you please add a comment explaining the above?
> 721: I guess a comment is needed to explain what the code is trying
> to do here. Why rescale the RSSI value to [0, MAX_RSSI]?
>
> | ACCEPT & EXPLAIN
> | Each wifi device has its own range of RSSI value. The wifi driver
> | IOCTLs defines the range of printed RSSI value between 0 and 15
> | (MAX_RSSI). So the device's RSSI value is rescaled.
> | Added comments to function wifi_getrssi() as below:
> |/*
> | * Rescale device's RSSI value to (0, 15) as required by WiFi
> | * driver IOCTLs (PSARC/2003/722)
> | */
Could you also explain why the range is [0, 15], as defined
in the PSARC case? Is this required by some third party
code? I am just curious why 15, not 10, not 100 :-)
> | ACCEPT
> | Changed to use cv_timedwait_sig(), thus 200000 is removed. And
> | WAIT_SCAN_MAX is re-defined to be maximum total scan wait time
> | as below.
> | /*
> | * maximum scan wait time in second.
> | * Time spent on scaning one channel is usually 100~200ms. The maximum
> | * number of channels defined in wifi_ioctl.h is 99 (MAX_CHANNEL_NUM).
> | * As a result the maximum total scan time is defined to be
> | * (200ms * 100 = 20s)
> | */
> | #define WAIT_SCAN_MAX 20
> | Actually the maximum channel number 99 is bigger than number of
> | standard 802.11 channels. And since this value is big enough, I'd
> | prefer to keep it staticly defined.
OK. Then maybe it should be defined as something like
#define WAIT_SCAN_MAX (200 * MAX_CHANNEL_NUM)
> | ACCEPT & EXPLAIN
> | If current state is RUN, the code just returns for a known bug.
> | 6212098 Ath driver can not scan out the new network name when
> | it is already connect with a wlan
> | Added comments and codes as below:
> | /* Return when current state is RUN for CR6212098 */
I guess it is better to put in the problem in a comment
instead of using the CR number.
> | EXPLAIN
> | The state is changed back to INIT only when original state is
> | also INIT. The reason is that at the end of SCAN stage, if an
> | AP is selected, the station will consequently connect to that
> | AP. Then it looks unreasonable that for a disconnected device,
> | a SCAN command causes it connected. So the state is changed back
> | to INIT.
Could you please put the above as a comment in the code?
--
K. Poon.
[EMAIL PROTECTED]
_______________________________________________
networking-discuss mailing list
[email protected]
