Thank you Seb!
Both of comments have been addressed.
Here are the updated webrevs:
Webrev generated to show change made in this round of code-review:
http://cr.grommit.com/~sshakya/libdlpi_webrev_followup/
Webrev generated against the ONNV gate:
http://cr.grommit.com/~sshakya/libdlpi_post_review/
Thanks,
sagun
Sebastien Roy wrote:
Sagun Shakya wrote:
webrev against last code review:
http://cr.grommit.com/~sshakya/libdlpi-webrev-review1/
Two cosmetic nit-picks:
usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_capture.c:
* 155, 206, 212: cstyle: need brackets
usr/src/lib/libdlpi/common/libdlpi.c:
* 1384: I'd prefer to see the DLPI macro names for these types here
instead of their constant values. For example, DL_ETHER instead of
0x04, etc.
Thanks,
-Seb
_________________________________
clearview-discuss mailing list
[EMAIL PROTECTED]
_______________________________________________
networking-discuss mailing list
[email protected]
