Roamer,
YunSong (Roamer) Lu wrote:
Your code looks workable for your case, but it's very strange for me.
The function hcksum_assoc() is used to associate h/w checksum
information to the mp mainly for inbound packet, so your way make the
usage of this function a little confusing.
How about try this way:
------------------
hcksum_retrieve(mp, NULL, NULL, &start, &stuff, NULL, NULL,
&tx_offload_flags);
mss = DB_LSOMSS(mp);
------------------
The LSO interface is still not public with GLDv3, so you can just use it
regardless of the impact by changes to mblk_t. With the further change
of LSO interface, all drivers in Solaris will be updated accordingly and
LSO capability negotiation will take care the compatibility problem.
I think his concern was that DB_* macros will break binary
compatibility should the layout of dblk_t changes. In fact,
this was the reason why we added hcksum_{assoc,retrieve}
accessor routines in the first place, and to have only the
ON code use the DB_* macros.
BTW, is there a reason why LSO and partial checksum mutually
exclusive?
Adi
Thanks,
Roamer
_______________________________________________
networking-discuss mailing list
[email protected]
