Hi David, Thanks for the review. Below is my response to your comments. Please let me know if you have any additional questions.
-- Quaker ===================================================== REVIEWER: [EMAIL PROTECTED] WEBREV: http://cr.grommit.com/~zf162725/cr_0308/ FILES: Misc NOTES: Description of feedbacks: ACCEPT Request accepted REJECT Request rejected EXPLAIN Explanation given DISCUSS Request requires further discussion to resolve DEFER Request deferred (e.g. because work is out-of-scope) ===================================================== usr/src/cmd/cmd-inet/usr.lib/wpad/driver.h usr/src/cmd/cmd-inet/usr.lib/wpad/eloop.h usr/src/cmd/cmd-inet/usr.lib/wpad/wpa_enc.h No comments. usr/src/cmd/cmd-inet/usr.lib/wpad/driver_wifi.c wpa_driver_wifi_get_bssid() line 64: (void) pthread_mutex_lock(&gbuf_lk); in case pthread_mutex_lock failed, it's better to use: assert(pthread_mutex_lock(&gbuf_lk) == 0)); Please correct other usage of pthread_mutex_lock() in the file | ACCEPT usr/src/cmd/cmd-inet/usr.lib/wpad/eloop.c 307 /* 308 * Terminate event loop even if there are registered events. 309 */ 310 void 311 eloop_terminate(void) 312 { 313 eloop.terminate = 1; 314 } I don't think you need this function at all. | EXPLAIN | The wpa daemon will register the signals of SIGINT, SIGTERM, SIGKILL; | when the daemon was killed, it will call eloop_terminate to terminate | the loop function eloop_run(), and then cleanup and exit. usr/src/cmd/cmd-inet/usr.lib/wpad/wpa_enc.c Looks to me pretty RFC 2104 compliant 138 if (a[i] != 0xa6) 139 return (-1); use if (a[i] != 0xa6) { return (-1); } | ACCEPT Besides, the change webrev is at: http://cr.grommit.com/~zf162725/cr_0327/ _______________________________________________ networking-discuss mailing list [email protected]
