Sebastien Roy wrote:
Garrett D'Amore wrote:
I've gone ahead and done a conversion of dmfe to GLDv3 (nemo). I
actually have a dmfe device on SPARC (in this case its on a SPARC
laptop), so I figured this would be beneficial.
I'd like to have folks review the work at
http://cr.grommit.com/~gdamore/dmfe_gldv3/webrev
This is refreshing. :-) Only a couple of comments:
usr/src/uts/sun4u/dmfe/Makefile
* No Comments
usr/src/uts/sun4u/io/dmfe/dmfe_main.c
* 33: is there no longer any kind of version number displayed by modinfo
for dmfe?
* 214: the dmfe_m_getcapab function unconditionally always returns
B_FALSE for all capabilities, so I'm wondering what the utility is in
providing an MC_GETCAPAB entrypoint at all for this driver.
* 596, 599: Why comment those out? You can still keep track of these
stats in dmfe_t even if GLDv3 doesn't yet ask you for these values,
right?
* 1158: Without context about pre-existing code having once been there
to process VLAN headers, this comment seems odd. I'd just blow this
comment away.
* 1349: cstyle; indent by 4.
Just as a follow-up, I nuked that DEBUG message altogether. DTrace
should be used instead.
I want to go on a mission to rip out a bunch of the debug stuff from
these drivers. I did a bunch for dmfe, but I missed that once, and
really it was a good candidate (since all the info it provides is easily
obtainable with the normal entry/exit probes in DTrace.)
-- Garrett
usr/src/uts/sun4u/io/dmfe/dmfe_mii.c
* No Comments
usr/src/uts/sun4u/sys/dmfe_impl.h
* No Comments
-Seb
_______________________________________________
networking-discuss mailing list
[email protected]
