Paul Durrant wrote:
<SNIP>
Few things...
- Are these sockets goind to obey 3SOCKET or 3XNET semantics?
They currently obeying 3SOCKET semantics, and it should probably stay
that way unless people have some concerns.
- I think the ksocket_t * should be the last arg. to ksock_socket().
In general my preference is for value-return args. to be at the end of
the list.
OK, noted. If I see more requests about changing the location of the
argument, then I will do so.
- Is ksock_set_nonblocking() necessary? Could this not be handled by
an option passed to ksock_setsockopt()?
It could. However, I am hesitant to introduce kernel-socket only socket
options.
- I think the ksock_callback_t passed to ksock_accept() is slightly
confusing. Is it really necessary for an accepted socket to
immediately have callbacks? It would be more straightforward if the
thread calling ksock_accept() simply called ksock_callback() upon its
return.
The issue with that is that an event might be missed, and the user would
have to check for "pending" events after registering the callbacks. The
current approach allows the user to do what you want by simply passing
in NULL for the last two arguments. Another approach would be to provide
two versions of accept; one that has the "regular" accept behavior, and
another that allows for callback registration.
Paul
Thank you very much for you comments,
Anders
_______________________________________________
networking-discuss mailing list
[email protected]
