> I got my second reviewer, so no need for anyone else > to review it if > they don't want to.
It is very good for you! > Of course, review feedback is > always appreciated... > I can always follow up with a 2nd RTI if it is > warranted. (Plus, I'll > be in this code again shortly, to add support for QFE > devices.) I understand you hasten the code to be reviewed. I'll focus and review the VLAN tagging, GLDv3 and hw checksum part of the code in one or two days, and will post the result here. Fortunately, I'm not so busy for my job on this week. But if I cannot that, I'm sorry :-) BTW what it RTI? -masa > masayuki Murayama wrote: > > Garrett, > > > > > >> I'm looking for folks to review my changes to hme. > I > > *cannot* commit > >> these changes if I don't get reviewers! > >> > >> The webrev is at > >> http://cr.opensolaris.org/~gdamore/nemo-hme > >> > >> These changes do the following for hme: > >> > >> * conversion to GLDv3 (mostly already > reviewed) > >> * add support for full-size VLAN frames > >> * add hardware checksum support (this is the part > >> I need, search for > >> SUM for most of the changes) > >> * optimize receive path slightly > >> e these changes get committed, hme will support > >> VLANs, trunking, > >> exclusive IP zones. It will also support hardware > >> checksum offload and > >> other tuning, getting about a 2% performance > increase > >> for most kinds of > >> traffic (as seen on a 360MHz system.) > >> > >> > > > > I think I can review that in a degree. I have > experience in > > implementing network drivers under GLDv3 and > solaris hardware > > checksum offloading. > > > > But I have a little problems: > > When is the dead line? I can work for that on > weekends only. > > I don't have experience of such reviews in > English. (I'm not > > a native english speaker. My english ability is > poor.) > > I don't have a sparc box. > > Does it matter? > > > > -masa > > > > > > This message posted from opensolaris.org > > _______________________________________________ > > networking-discuss mailing list > > [email protected] > > > > _______________________________________________ > networking-discuss mailing list > [email protected] This message posted from opensolaris.org _______________________________________________ networking-discuss mailing list [email protected]
