> > > Also, I think you'd end up sending ICMP port unreachables to packets > > > that are not addressed to your IP address when dhcpinit it set. Or does > > > the fact that we end up with an IRE_BROADCAST prevent that? (I don't > > see > > > ll_multicast being checked whether we send ICMP errors.) > > > > I'm not sure I'm following you here, but the only relevant codepath I see > > that generates ICMP port unreachable errors is in ip_fanout_udp(), and > > that code is bracketed by `!broadcast'. > > ip_fanout_send_icmp is called in a few more places: > ip_proto_not_sup > ip_fanout_proto
Those places appear to be called for "protocol unreachable" messages, not "port unreachable" messages -- hence my confusion on your original post. > At least for the second one I don't see a broadcast check. > > You are saved by the fact that you check for IPPROTO_UDP and the bootp > port in ip_input() in the latest webrev. OK :-) -- meem _______________________________________________ networking-discuss mailing list [email protected]
