Peter Memishian wrote:
> > This is what happens when folks just blithely promote to public APIs
> > that are used internally without some basic review. I would probably
> > have complained loudly about the side effect at any ARC review, but the
> > promotion occurred before I had any ARC participation.
>
> The core issue with mcopymsg() (and the rest of the promoted strsun.c
> routines) is that there were already consumers outside of ON despite being
> labeled Consolidation Private, and changing the semantics for freemsg()
> would break them rather badly.
>
Then those interfaces should not have been promoted, IMO. Instead,
leave a contract in place, and provide suitable replacements for truly
public consumption that either lack the side effect, or make it clear
that a side effect exists (mcopyandfreemsg().). As I pointed out
earlier, there are cases where that side effect is toxic, and mcopymsg()
cannot be used.
-- Garrett
_______________________________________________
networking-discuss mailing list
[email protected]
