Darren Reed writes: > Whilst experimenting, I ran across a few trivial bugs that I've > fixed along the way...of these 4, one is still pending acceptance: > 6678354. Does anyone have any thoughts on this problem or > other ways in which it should be fixed?
Please make sure that you're listed as the RE on all of the bugs, you've got a filled out 'Evaluation' field, and the state is 'fix-in-progress.' > If someone has some time to code review this, please look at: > http://cr.opensolaris.org/~darrenr/biscuit_onnv_6678274-20080325/ revarp.c 374: this return leaks the 'dh' handle. (Since this rarely happens, couldn't this just be another test near line 386?) ifconfig.c 2884: while you're here doing cosmetic stuff, lifr_metric isn't right. This should be lifr_mtu. (Cut-n-paste, I guess.) The other changes look ok. -- James Carlson, Solaris Networking <[EMAIL PROTECTED]> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 _______________________________________________ networking-discuss mailing list [email protected]
