Hi Folks, I'm looking for code-reviewers for the following set of changes:
PSARC 2008/473 Fine-Grained Privileges for Datalink Administration 6695904 least privileges for datalink actions 6729477 pcwl accidentally requires privileges for WLAN_GET_PARAM ioctl 6679049 ucred_t leak in dlmgmtd Webrev: http://cr.opensolaris.org/~seb/dladm-privs-webrev/ Don't be put-off by the webrev's claim of 1800+ lines of changes, as only 800 or so of those lines are modified or new. There are over 1000 lines of deleted code. Workspace with cscope database: /net/zhadum.east/export/ws/seb/dladm-privs-hg/ The high-level architecture behind the change is described in the PSARC fast-track case log: http://www.opensolaris.org/os/community/arc/caselog/2008/473/ One thing to keep in mind while reviewing these changes is that the dld control device is no longer a STREAMS device, but a regular character device. For one, STREAMS serves no purpose here. The device simply processes GLDv3 ioctls, and that's it. Removing STREAMS from this part of the framework makes the code simpler and removes the data-size limitations that the Crossbow project has run into with I_STR. One additional note is that I haven't done any install testing yet, and one issue that I may run into is the presence (or lack thereof) of the /dev/dld device link at first boot. I may need to ship a /dev/dld link as part of the SUNWcsd package to make sure that the link always exists. Thanks in advance, -Seb _______________________________________________ networking-discuss mailing list [email protected]
