that's fine, thanks. will revert changes in crossbow. eric
Sebastien Roy wrote: > Hi Eric, > > On Tue, 2008-08-26 at 16:14 -0700, Eric Cheng wrote: >> I am sorry for not looking at this earlier. >> I found 2 things but it's ok to not fix them if you already RTI'ed. > > Actually, I've already putback to onnv. :-} > >> http://cr.opensolaris.org/~seb/dladm-privs.3/ >> >> 1. not using DDI_DEFINE_STREAM_OPS in aggr/vnic >> >> I don't see the reason for this. aggr/vnic are still streams drivers >> (use mac_init_ops()) just like other gldv3 drivers. they make use of the >> dld control node but they themselves are not control nodes. if a >> physical nic driver can use this macro I don't see why aggr/vnic cannot. > > I don't have a strong preference here. I wouldn't complain if you > revert this change in the Crossbow gate. > >> 2. removal of the rvalp arg from the ioctl signature. >> >> the rvalp is useful if you want the ioctl to return something other than >> 0 or -1. e.g. if you want to have your own error space other than use >> the unix error space, you can return the error code this way. without >> this, you'd have to embed a diagnostic value in each of your ioctl >> command structures, which would still work but is not an ideal solution. >> >> this feature is not being used now but it'd be better to not have to >> change the framework (and all control nodes) when we do use it later. > > I removed them as I didn't foresee their being used in the future, but > similar to the above, I wouldn't complain if you add this argument back > when merging with Crossbow. > > Thanks, > -Seb > > _______________________________________________ networking-discuss mailing list [email protected]
