[email protected] wrote:
On (07/03/09 18:27), zeeshanul huq - Sun Microsystems - Beijing China wrote:
I suggest we provide two types of private properties: one is visible,
another is hidden.
One example of visible private properties is _adv_2500fdx_cap and
_adv_2500fdx_en of bnxe driver. They are private only because they are
not common (yet?), I think.
We discussed this in the early phases of Brussels, and having this
gray area of "somewhat public" was discarded for the reason that it
gets confusing.. in the 2500fdx example, the property will become public
as the feature becomes common, and that natural evolution should work
ok.
But device drivers evolve faster than the kernel. It seems unfair to
hold back 3rd party drivers here.
Although, admittedly, the lack of a GLDv3 public API is already
effectively doing that.
And an example of hidden private properties is the _drain_max property
of bge driver. It is a tunable just for developers and PAE to tune the
driver, because we don't think 64 is the ultimate perfect value.
right, and drain_max is a good example of something that we don't want
to display in the default 'show-linkprop' output- a perfect "dont try this
without supervision" tunable.
I think there is a case for properties that that aren't displayed "by
default", but are still accessible via some extended flags. (E.g. "dladm
show-private" or somesuch.) The output from that command could include
text to this effect:
"These properties are specific to the device driver. Please refer to the
documentation for the device driver before
making changes to them."
-- Garrett
--Sowmini
_______________________________________________
networking-discuss mailing list
[email protected]
_______________________________________________
networking-discuss mailing list
[email protected]
