> General: There are quite a bit of changes related to the style of
> local variable declaration that was changed, thus adding to the volume
> of the review. In general, it would be preferable to restrict the set
> of changes to the functionality being added, and to cstyle and lint
> issues found while making these changes. Otherwise, sticking with the
> existing style of the file without making sweeping changes to style
> based on personal preference should be the modus operandi. I won't
> comment on each instance, I've restricted my specific comments to
> things not related to local variable declarations. :-)
I'd go a step further and demand that all changes that are related to
separating initializers from declarations be reverted. For instance,
for no apparent reason, this:
537 static int
538 ipnet_close(queue_t *rq)
539 {
540 ipnet_t *ipnet = rq->q_ptr;
541 ipnet_stack_t *ips = ipnet->ipnet_ns->netstack_ipnet;
... was expanded to:
588 static int
589 ipnet_close(queue_t *rq)
590 {
591 ipnet_stack_t *ips;
592 ipnet_t *ipnet;
593
594 ipnet = rq->q_ptr;
595 ips = ipnet->ipnet_ns->netstack_ipnet;
The original code was correct and wholly unobjectionable -- and the latter
form suggests to the reader that there is something subtle going on that
required it, which is not true.
--
meem
_______________________________________________
networking-discuss mailing list
[email protected]
