With the design review wrapping up (but we are still accepting comments)
it is time to start the code review.
First let's remind ourselves the purpose of the review. The key purpose is:
- to find bugs or latent bugs by inspecting the code.
- to reduce the risk of bugs being introduced in the future by making
sure that the code and comments are reasonably clear; comments should be
technically correct and helpful (as opposed to confusing)
For some code reviews I seen in the past there has been stylistic
comments around number of tabs, 80 column fill, etc.
I don't view comments relating to white space as consistent with the
purpose above. The code passes the cstyle checker. However, there might
be places where the code is inconsistent with the cstyle document (which
covers a bit more than what the cstyle checker can check). But apart
from that, there is plenty of code to review for correctness and
comments to review for clarity so please don't spend time on stylistic
comments.
There are a few "tags" in comments which will be removed after the code
review; they serve as tags to point out interesting things for different
reviewers. We have
XTX For trusted extensions
XIPSEC For IPsec interaction
XTBD General comments, including forward looking statements
Please let us know what parts or aspects of the code you will review, so
we can track that. For instance, parts like TCP, SCTP, iptun are
contained in separate files while aspects like TX, IPsec, and routing
are spread out across the files.
The webrev for usr/src is at
http://cr.opensolaris.org/~nordmark/refactor-review/
There are some changes to the closed tree (to SDP) which have already
been reviewed. If anybody wants to look at those they are available
internally at
http://jurassic-x4600.sfbay/home/nordmark/hg/refactor-review/usr/closed/webrev/
For those that are internal to Sun and want to use cscope, that is
available at:
/net/npt.sfbay/export/refactor/refactor-review/usr/src/uts
and
/net/npt.sfbay/export/refactor/refactor-review/usr/src
Other should be able to pull the source from
ssh://hg.opensolaris.org//hg/ip-refactor/refactor-gate
ip_newroute delenda est,
Erik
_______________________________________________
networking-discuss mailing list
[email protected]
