On (10/09/09 14:17), Peter Memishian wrote:
> > http:://cr.opensolaris.org/~sowmini/jim_review
>
> Can `dummymodinfo' please be moved to a header file?
I've moved it to ip_arp.h (all other uses of it acquire the streamtab
definition by #including inetddi.c (which then has the extern declaration),
and I don't want to get into the business of restructuring all that
code at this time.
> Also, in arp_push_on_driver() (which seems like it should be static and
> named arp_over_driver()), the Q2NAME() will make the check more readable
> and safer (not all modules have a non-NULL q_info). Also, please
> explictly check against the return value from strcmp(). e.g.:
>
> static boolean_t
> arp_over_driver(queue_t *q)
> {
> queue_t *qnext = STREAM(q)->sd_wrq->q_next;
>
> return (qnext != NULL &&
> strcmp(Q2NAME(qnext), IP_MOD_NAME) != 0 &&
> strcmp(Q2NAME(qnext), UDP_MOD_NAME) != 0);
> }
fixed, thanks for the suggestion. webrev at
http://cr.opensolaris.org/~sowmini/jim_review
--Sowmini
_______________________________________________
networking-discuss mailing list
[email protected]
