Gordon Ross wrote:
> Please review:
>
> http://cr.opensolaris.org/~gwr/snoop/
Some nits:
- snoop_smb.c:527: "*p" probably isn't a good name for a variable with
function-level scope.
- should be using snprintf instead of sprintf, certainly for new code,
likely for anything touched, and (with some RTI Advocates) requested
for all code in the same file.
- what happened to the error class decode when in detail mode and
non-NT traffic?
--
James Carlson 42.703N 71.076W <[email protected]>
_______________________________________________
networking-discuss mailing list
[email protected]
