On Thu, Aug 05, 2010 at 04:56:26PM -0500, Nicolas Williams wrote:
> On Thu, Aug 05, 2010 at 02:03:28PM -0700, John Fischer wrote:
> > The code review is located at:
> >
> > http://cr.opensolaris.org/~johnfisc/nodename-6974969
>
...
> - usr/src/cmd/cvcd/sparc/sun4u/starfire/cvcd.c:206
>
> Style: not your code, but, I prefer to not use '!' to check == 0:
>
> 204 206 if (strlen(hostname) == 0) {
>
> instead of
>
> 204 206 if (!strlen(hostname)) {
>
I haven't done my code review yet, but I prefer
if (strlen(hostname) == 0) {
It says explicitly what you're checking. Even though I've seen it a
million times, I always have to stop and think about the ! form.
I don't want to start a big debate. I think that it's just a matter of
personal style, so I'll go with whatever you and Nico decide.
tom
_______________________________________________
networking-discuss mailing list
[email protected]
