On Wed, 2006-10-25 at 16:37 +0300, Tambet Ingo wrote: > Hey, > > There are some issues with importing .pcf files. First, we're trying to > parse them with GKeyFile which is a bit different from pcf files: The > character for comments is '#' (instead of ';'), section names and key > names are case sensitive (instead of ... well, case insensitive). > The .pcf file also has a format "!key" which means "'key' and it's not > changeable by user" instead of literal "!key" key. > > So here's a patch to implement a simple parser for pcf files. > Additionally, this patch makes the importer use same rules as the UI for > required keys (for example, there's no reason a .pcf file must contain > key 'NTDomain'). As a bonus, it also fixes a memory leak (loaded routes > were never freed).
Is this targetted for HEAD, stable, or both? Looks good from a quick check, feel free to commit to HEAD at least. I'll take a longer look if you want to commit to stable too, just let me know. Thanks! Dan > Tambet > _______________________________________________ > NetworkManager-list mailing list > NetworkManager-list@gnome.org > http://mail.gnome.org/mailman/listinfo/networkmanager-list _______________________________________________ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list