This is the second version, respinned with suggestions from first round implemented. More specifically:
* Fixed the parenthesis-related coding style bugs (hope I found all of them) * Settings for Encapsulation and Protocol now lowercased * Add checks in settings verify() for VCI/VPI numerical format and for password length. * Hack nm_device_get_priority() instead of changing the indexes in DeviceType enum to achieve getting priority. Pantelis Koukousoulas (3): ADSL: Settings and initial "scaffolding" From b2ca72f83283df313046c72ca3ca7296f8cb1537 Mon Sep 17 00:00:00 2001 From: Pantelis Koukousoulas <pkt...@gmail.com> Date: Wed, 11 May 2011 19:28:25 +0300 Subject: [PATCH 2/3] ADSL: Carrier Handling and PPP support ADSL: Add libnm-glib and nmcli code cli/src/connections.c | 66 ++++- cli/src/devices.c | 4 + cli/src/settings.c | 50 ++++ cli/src/settings.h | 2 + include/NetworkManager.h | 3 + introspection/Makefile.am | 1 + introspection/nm-device-adsl.xml | 15 + libnm-glib/Makefile.am | 6 + libnm-glib/libnm-glib.ver | 4 +- libnm-glib/nm-device-adsl.c | 236 +++++++++++++++ libnm-glib/nm-device-adsl.h | 62 ++++ libnm-glib/nm-device.c | 10 +- libnm-util/Makefile.am | 2 + libnm-util/libnm-util.ver | 12 + libnm-util/nm-connection.c | 25 ++- libnm-util/nm-connection.h | 2 + libnm-util/nm-setting-adsl.c | 540 ++++++++++++++++++++++++++++++++++ libnm-util/nm-setting-adsl.h | 97 ++++++ src/Makefile.am | 6 + src/nm-device-adsl.c | 596 ++++++++++++++++++++++++++++++++++++++ src/nm-device-adsl.h | 60 ++++ src/nm-device.c | 8 +- src/nm-udev-manager.c | 49 +++- src/ppp-manager/nm-ppp-manager.c | 31 ++- src/settings/nm-settings.c | 2 + 25 files changed, 1869 insertions(+), 20 deletions(-) create mode 100644 introspection/nm-device-adsl.xml create mode 100644 libnm-glib/nm-device-adsl.c create mode 100644 libnm-glib/nm-device-adsl.h create mode 100644 libnm-util/nm-setting-adsl.c create mode 100644 libnm-util/nm-setting-adsl.h create mode 100644 src/nm-device-adsl.c create mode 100644 src/nm-device-adsl.h -- 1.7.4.1 _______________________________________________ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list